Skip to content

Docs(build): linklint is now called sphinx_linklint - #156373

Merged
nedbat merged 4 commits into
python:mainfrom
nedbat:nedbat/sphinx-linklint
Aug 25, 2026
Merged

Docs(build): linklint is now called sphinx_linklint#156373
nedbat merged 4 commits into
python:mainfrom
nedbat:nedbat/sphinx-linklint

Conversation

@nedbat

@nedbat nedbat commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

It looks like I updated pylock.toml correctly. Is there a reason we don't put that uv pip compile command in the Makefile? I also added make lock to remember the command.

StanFromIreland
StanFromIreland reviewed Aug 25, 2026
View reviewed changes
Comment thread Doc/Makefile Outdated
@read-the-docs-community

read-the-docs-community Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34228969 | 📁 Comparing c159734 against main (5f31aee)

  🔍 Preview build  

1 file changed
± library/os.html

StanFromIreland
StanFromIreland approved these changes Aug 25, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nedbat
nedbat merged commit 98bd716 into python:main Aug 25, 2026
34 checks passed
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 25, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thanks @nedbat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thanks @nedbat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thanks @nedbat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Sorry, @nedbat, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 98bd716479dacb1e618a4271df10b2b67c010c4c 3.14

@miss-islington-app

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Sorry, @nedbat, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 98bd716479dacb1e618a4271df10b2b67c010c4c 3.13

@miss-islington-app

miss-islington-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

Sorry, @nedbat, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 98bd716479dacb1e618a4271df10b2b67c010c4c 3.15

hugovk
hugovk reviewed Aug 25, 2026
View reviewed changes
Comment thread Doc/Makefile
# Dependencies have a 14 day cooldown period to mitigate supply chain attacks,
# except for sphinx_linklint and python-docs-theme, which are maintained by
# core team members.
uv pip compile requirements.txt \

@hugovk hugovk Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile has a $(UV) var we could use here.

@nedbat nedbat Aug 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad.

@nedbat
nedbat deleted the nedbat/sphinx-linklint branch August 25, 2026 23:25
@bedevere-app

bedevere-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

GH-156427 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 26, 2026
@bedevere-app

bedevere-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

GH-156428 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 26, 2026
@bedevere-app

bedevere-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

GH-156429 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 26, 2026
nedbat added a commit that referenced this pull request Aug 26, 2026
@nedbat @StanFromIreland
[3.13] Docs(build): linklint is now called sphinx_linklint (GH-156373) (
f82d96d 
#156427)

* Docs(build): linklint is now called sphinx_linklint

---------
(cherry picked from commit 98bd716)

Co-authored-by: Stan Ulbrych <stan@python.org>
nedbat added a commit that referenced this pull request Aug 26, 2026
@nedbat @StanFromIreland
[3.14] Docs(build): linklint is now called sphinx_linklint (GH-156373) (
199d88e 
#156428)

* Docs(build): linklint is now called sphinx_linklint

---------
(cherry picked from commit 98bd716)

Co-authored-by: Stan Ulbrych <stan@python.org>
hugovk pushed a commit that referenced this pull request Aug 27, 2026
@nedbat @StanFromIreland
[3.15] Docs(build): linklint is now called sphinx_linklint (GH-156373) (
89afe3e 
#156429)

(cherry picked from commit 98bd716)

Co-authored-by: Stan Ulbrych <stan@python.org>
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Aug 27, 2026
@nedbat @StanFromIreland @clin1234
Docs(build): linklint is now called sphinx_linklint (python#156373)
fe2ea67 
* Docs(build): linklint is now called sphinx_linklint

* Docs(build): move the lock command to the Makefile

* Update Doc/Makefile

Co-authored-by: Stan Ulbrych <stan@python.org>

* Add a comment clarify cooldown (and excludes) and add to `make help`

---------

Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@nedbat nedbat

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nedbat @hugovk @StanFromIreland